Updated Kotlin to 1.6.21 with HMPP enabled #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkivanov
force-pushed
the
update-kotlin-to-1.6.21
branch
from
d497b96
to
01a2682
Compare
|
@CherryPerry Could you please run builds? I want to check if it compiles on CI. Thanks! |
CherryPerry
reviewed
May 1, 2022
reaktive/src/jsMain/kotlin/com/badoo/reaktive/utils/SynchronizedCompat.kt
Show resolved
Hide resolved
arkivanov
force-pushed
the
update-kotlin-to-1.6.21
branch
from
01a2682
to
9888e97
Compare
|
@CherryPerry This PR is ready for review, thanks! |
CherryPerry
approved these changes
May 2, 2022
reaktive/src/darwinCommonMain/kotlin/com/badoo/reaktive/scheduler/MainScheduler.kt
Show resolved
Hide resolved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Kotlin to 1.6.21 and coroutines to 1.6.1. Since Kotlin 1.6.20, HMPP is enabled by default. So this PR is a follow-up to #638.
KT-48811 is marked as fixed, however it's still relevant and is now being tracked in KT-52193. Because of this, I had to supply default values to atomics in shared source sets, even though they have default values specified in
expectcommon.