[2.0] Fixed subjects not emitting initial values synchronously on subscription under load #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkivanov
changed the title
CherryPerry
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to use a singly-linked queue. On each subscription, acquire the current head and emit the item (or all items till the end, depending on the type of the subject). Then pass the last emitted item via serializer and emit any new items when processed.
Observers must not miss any new items that are sent to the subject cuncurrently after initial items are emitted (synchronously on subscription). E.g. if
BehaviorSubjectholds item A, and a new observer receives that item synchronously on subscription, and new items B, C and D are sent to the subject concurrently, then that observer must receive B, C and D eventually.Fixes #727