Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Better formatted reviews #40

Closed
crh0831 opened this issue Sep 1, 2022 · 3 comments
Closed

Feature Request: Better formatted reviews #40

crh0831 opened this issue Sep 1, 2022 · 3 comments

Comments

@crh0831
Copy link

crh0831 commented Sep 1, 2022

I often copy/paste quotes or passages from book in my reviews, and I've found that the review text box does not respect line breaks. (See screenshot)
At the least could it be configured to break lines, so the text flows in the text box?
A better (but potentially more difficult) would be to enable Markdown formatting the review text box.

Screenshot 2022-09-01 160800
@bayang
Copy link
Owner

bayang commented Sep 2, 2022

Ok, that's weird because it should be supported.

I'll have a look at it.

@crh0831
Copy link
Author

crh0831 commented Sep 8, 2022 •
edited
Loading

I don't know if this helps or not, but I was messing around with the developer tools in my browser and was able to affect the display of the .card CSS element by messing with the attributes. Changing overflow:hidden to overflow:auto at least gave me a scrollbar in the review box. Not great, but better. I don't understand the CSS inheritance enough to suggest a better solution.

bayang added a commit that referenced this issue Sep 13, 2022
@bayang
feat: use markdown to write reviews #40
0e11bbb 
There is now a code editor and a markdown preview of the review text.
github-actions bot pushed a commit that referenced this issue Sep 13, 2022
@semantic-release-bot
chore(release): 0.30.0 [skip ci]
329b2c3 
## [0.30.0](v0.29.0...v0.30.0) (2022-09-13)

### Features

* use markdown to write reviews [#40](#40) ([0e11bbb](0e11bbb))

### Bug Fixes

* increase password length in login input [#43](#43) ([7568cc9](7568cc9))
* prevent temporary cover images conflicts in caches [#41](#41) ([b1482e1](b1482e1))
@bayang
Copy link
Owner

bayang commented Sep 13, 2022

Should be fixed in v 0.30.0

@bayang bayang closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bayang @crh0831