Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to modify event dates on 0.33.0 #49

Closed
jrhbcn opened this issue Oct 24, 2022 · 3 comments
Closed

Bug: Unable to modify event dates on 0.33.0 #49

jrhbcn opened this issue Oct 24, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jrhbcn
Copy link

jrhbcn commented Oct 24, 2022

Hi,

First of all, let me say thanks for your new release 0.33.0 @bayang. It really fits my needs now. However, I am experiencing some problems updating from my previous version. Let me show you an example: This is the status of a book in the previous version:
image

Updating to 0.33.0 it results in the following events. This is correct as I was understanding events wrong and duplicated them to see both start and end dates. So the result is this:
image

The problem is that I seem to be unable to change the event dates on them. What I do is delete the reading event of the 30th of July (works) but then editing the finished event to change the start date to the 26th of May and nothing happens, the submit button seems unresponsive (and no log is printed):

image

I need to remove all events and then create a new finished one with the same start and end dates and it works. Is there something I need to do to be able to update them? Thanks again for taking your time to look at this.

@bayang
Copy link
Owner

bayang commented Oct 24, 2022

Hi @jrhbcn I found what is happening.
Since it is now possible to edit dates, I added validation to prevent people from storing inconsistent event dates (for example with a start date after the end date).
This is what happen in your case, the backend won't let you set the event date to be before the start date that is stored in the database (30 july 2022).
The validation is a bit too aggressive, I'll have to change it a bit since in your case you are also editing the startdate.

@bayang bayang added the bug Something isn't working label Oct 24, 2022
github-actions bot pushed a commit that referenced this issue Oct 24, 2022
### [0.33.1](v0.33.0...v0.33.1) (2022-10-24)

### Bug Fixes

* date handling in history view after events modification ([1d2edd9](1d2edd9))
* impossible to edit an event in some conditions [#49](#49) ([cfa0ad1](cfa0ad1))
@bayang
Copy link
Owner

bayang commented Oct 24, 2022

Should be fixed in v0.33.1

@bayang bayang closed this as completed Oct 24, 2022
@jrhbcn
Copy link
Author

jrhbcn commented Oct 24, 2022

And it is indeed fixed in version 0.33.1. Thanks again for being so responsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants