Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS-specific BAZELISK_HOME #474

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

mzapotoczny
Copy link
Contributor

BAZELISK_HOME should be set as absolute path, but all supported OSes use different folder structure. This might be a problem if we want to globally set BAZELISK_HOME for all developers.

Therefore we want to propose a change to add support for OS-specific BAZELISK_HOME, for example BAZELISK_HOME_WINDOWS.

@google-cla
Copy link

google-cla bot commented Jun 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mzapotoczny
Copy link
Contributor Author

@fweikert could you take a look? Thanks in advance :)

@McAmun
Copy link

McAmun commented Dec 4, 2023

@fweikert - could you please have a look on that change ?

@McAmun
Copy link

McAmun commented Feb 27, 2024

@katre can you maybe help here ?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@McAmun
Copy link

McAmun commented Jul 26, 2024

@fweikert any update on this ?

@McAmun
Copy link

McAmun commented Sep 5, 2024

@fweikert @meteorcloudy - Can we get this merged please ? We would like to start using your official releases.

@fweikert
Copy link
Member

fweikert commented Sep 6, 2024

@mzapotoczny thanks for this change, I took the liberty of resolving the merge conflict.

@fweikert fweikert merged commit 0b27498 into bazelbuild:master Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants