Added update known shas to include T1-T2 triples #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this is a performance regression. Does anyone have a sense for how big |
illicitonion
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds known sha256 entries for all T1 and T2 platform triples for Rust 1.67.0. While not all platforms are supported in the current version of
rules_rust(or even Bazel), including them can skip a performance regression for users using these unique platforms in their own projects. This change is intended to avoid situations where a switch to Bazel or successfully cross-compiling doesn't feel unnecessarily slow as users wait for Bazel to re-download toolchains (related to #1825).