Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for unnamed workspaces/modules when using crates_vendor #2730

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

AmeliasCode
Copy link
Contributor

Addresses #2661

If the workspace name is empty, the crate_module_template will use a label like Label(//<stuff>) instead of Label(@//<stuff>)

Most of the changes in this are just regenerating the vendor'ed crates in the examples. I ran the tests in all the relevant examples to ensure they still worked.

@AmeliasCode AmeliasCode marked this pull request as draft July 6, 2024 21:32
@AmeliasCode
Copy link
Contributor Author

Seems like the ios failure is unrelated to the change? Is it possible to rerun that test and see?

@AmeliasCode AmeliasCode marked this pull request as ready for review July 6, 2024 23:09
@AmeliasCode AmeliasCode marked this pull request as draft July 6, 2024 23:16
@AmeliasCode AmeliasCode marked this pull request as ready for review July 7, 2024 00:07
@AmeliasCode
Copy link
Contributor Author

@illicitonion Hi! Could you take a look at the failure in the CI run and let me know if that looks like an issue with my change? It looks like the tests passed but uploading to Kite failed?

Thanks!

@AmeliasCode
Copy link
Contributor Author

Looks like everything is passing now! :)

@AmeliasCode
Copy link
Contributor Author

@illicitonion or @UebelAndre could one of you please take a look at this PR? Thanks!!

@jondo2010
Copy link
Contributor

I was also just bitten by this issue, trying to use https://github.com/dtolnay/cxx from my project. Can confirm, this PR fixes the underlying issue (but still need to update the vendored build files in cxx).

@AmeliasCode
Copy link
Contributor Author

@illicitonion or @UebelAndre Just a friendly ping! Let me know if there is someone else I should message about this! Thanks!!

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry about the delay here!

@illicitonion illicitonion added this pull request to the merge queue Jul 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2024
@illicitonion illicitonion added this pull request to the merge queue Jul 29, 2024
Merged via the queue into bazelbuild:main with commit f0276ea Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants