-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for unnamed workspaces/modules when using crates_vendor #2730
Conversation
Seems like the ios failure is unrelated to the change? Is it possible to rerun that test and see? |
@illicitonion Hi! Could you take a look at the failure in the CI run and let me know if that looks like an issue with my change? It looks like the tests passed but uploading to Kite failed? Thanks! |
Looks like everything is passing now! :) |
@illicitonion or @UebelAndre could one of you please take a look at this PR? Thanks!! |
I was also just bitten by this issue, trying to use https://github.com/dtolnay/cxx from my project. Can confirm, this PR fixes the underlying issue (but still need to update the vendored build files in |
@illicitonion or @UebelAndre Just a friendly ping! Let me know if there is someone else I should message about this! Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry about the delay here!
Addresses #2661
If the workspace name is empty, the crate_module_template will use a label like
Label(//<stuff>)
instead ofLabel(@//<stuff>)
Most of the changes in this are just regenerating the vendor'ed crates in the examples. I ran the tests in all the relevant examples to ensure they still worked.