Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prost (proto) dependencies to latest versions #2810

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Aug 25, 2024

This change also bumps the min tested Rust version to Rust 1.72.1 which is about a year old at this point.

@UebelAndre
Copy link
Collaborator Author

I do not know how to update MOUDLE.bazel. The packages there seem to be a subset of what's needed I can't find notes on how it's supposed to be updated

relates to #2368

@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Aug 25, 2024

I do not know how to update MOUDLE.bazel. The packages there seem to be a subset of what's needed I can't find notes on how it's supposed to be updated

relates to #2368

I ended up looking at @rules_rust//proto/prost/private/3rdparty/crates/BUILD.bazel and copying the repositories from all aliases and manually updating MODULE.bazel as well as manually adding rules_rust_prost and rules_rust_prost__heck. This really should be something crate_universe does automatically (since I already used crates_vendor to update the dependencies).

@UebelAndre UebelAndre added this pull request to the merge queue Aug 26, 2024
Merged via the queue into bazelbuild:main with commit a5f7464 Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants