Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runfiles::rlocation! to return Option instead of panicing #2847

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update runfiles::rlocation! to return Option instead of panicing #2847

merged 2 commits into from
Sep 10, 2024

Conversation

UebelAndre
Copy link
Collaborator

closes #2653

@UebelAndre UebelAndre mentioned this pull request Sep 8, 2024
Closed
@UebelAndre UebelAndre changed the title Update runfiles API to return Result instead of panicing Update runfiles::rlocation! to return Option instead of panicing Sep 8, 2024
illicitonion
illicitonion approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@UebelAndre UebelAndre added this pull request to the merge queue Sep 10, 2024
Merged via the queue into bazelbuild:main with commit d07ac80 Sep 10, 2024
4 checks passed
@felipeamp felipeamp mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runfiles should return Result instead of panicing
2 participants
@UebelAndre @illicitonion