Drop broken symlinks #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e mocked and we can have more confidence in the tests. Had to also add more logic around symlinks
andysteadbbc
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧐 What?
Aim: handle repos that contain broken symlinks
The 'recursive-readdir' library that we have been using still does not handle broken symlinks so nothing gets generated/uploaded.
If there are broken symlinks to files then skip them.
Still need to decide how to handle broken symlinks to dirs...or in fact good symlinks to dirs...
Done a manual test with a symlink to a dir and it seems to be just ignored.
I think this is reasonable :-)
Added replacement for 'recursive-readdir' that just uses node's fs
🛠 How
make use of the recursive option available from node 18+ in fs.readdirSync
unit test is added.
new Dirent('directory', constants.UV_DIRENT_DIR)which is do-able...
🐞 Related issue
https://jira.dev.bbc.co.uk/browse/CLOUDPLAT-432