Merge ZoomView and Overview into a single WaveformView object #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to build artifacts to run tests anymore.
They can be configured independently but lack of a few singular features for now (ref rectangle, event subscription, zoom lock)
thom4parisot
changed the title
chrisn
force-pushed
the
master
branch
2 times, most recently
from
0e6b861
to
b8c6557
Compare
chrisn
force-pushed
the
master
branch
2 times, most recently
from
38e7da9
to
bb8dbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main benefit is to have a single codebase with features to work out what a waveform is.
It will allow in the future to have as many waveform views as necessary: