Added 'containers' option #258
Conversation
- Added demo pages - Update unit tests - Avoid resampling waveform to zero width - Don't hide container elements on resize - Fix overview waveform rendering on resize
- Instances should be created via 'Peaks.init()', rather than 'new Peaks()' - Added WaveformBuilder class, to separate requesting / creating waveform data from view initialisation - Added ViewController - Removed 'error', 'waveform_ready.zoomview', 'waveform_ready.overview' events
|
@chrisn - this looks pretty helpful! I would also like to be able to toggle zoomed/normal container programmatically. So the use case I'm thinking of would be a 'show more' button that then displayed the zoomable section. Is it possible to choose which of the containers appears on top? (at the moment the zoomed container is always on top?) |
But also... if these were useful, I think that should be a separate pull request. Being able to hide one or another container would be immediately useful. |
Yes, let's follow this up in a separate issue / PR.
This is controlled by your page layout and styling. If you want the zoomed container to appear below, you can order the <div id="waveform-container">
<div id="overview-container"></div>
<div id="zoomview-container"></div>
</div> |
Use leading underscore for private member variables
This pull request adds a
containersoption that allows users to select whether the overview waveform, zoomable waveform, or both, are rendered. See #2, #222, #53, #193, #46.