Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][NRPTI-1262] redirect link on bcmi that directs to the corresponding search on nrced #1267

Merged
merged 4 commits into from
Aug 15, 2024
Merged

[FEATURE][NRPTI-1262] redirect link on bcmi that directs to the corresponding search on nrced #1267

merged 4 commits into from
Aug 15, 2024

Conversation

sggerard
Copy link
Contributor

@sggerard sggerard commented Aug 14, 2024 •
edited
Loading

Description

This PR includes the following proposed change(s):

  • Add mineNo to core mine records
  • Update NRIS-EPD & NRIS-EMLI importers to link better to core mines using the projectName field
  • Add support for searching in NCRED via project/projectName
  • Fixing of automated tests

@sggerard sggerard linked an issue Aug 14, 2024 that may be closed by this pull request
redirect link on BCMI that directs to the corresponding search on NRCED #1262
Closed
@sggerard sggerard requested a review from a team August 14, 2024 23:01
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sggerard sggerard merged commit 165fba4 into master Aug 15, 2024
6 checks passed
@sggerard sggerard deleted the 1262-redirect-link-on-bcmi-that-directs-to-the-corresponding-search-on-nrced branch August 15, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatchpole acatchpole acatchpole approved these changes

Assignees
No one assigned
Labels
Backend Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redirect link on BCMI that directs to the corresponding search on NRCED
2 participants
@sggerard @acatchpole