Allow for local file references in requirements when building AppImages #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any attempt to use a local file reference a requirements list would fail on Linux AppImage because the file reference wouldn't be valid inside the Docker container
This PR modifies the build process, transforming the requirements when invoked from within a Docker context, adding a Docker filesystem mount for each individual local file requirement (Fixes #992).
It also modifies the Open command on AppImage under Docker so that open will start a shell session in the docker container. This container will honor the filesystem mounts needed for any app or test requirements. Strictly, this is a separate feature; but it was needed to debug the former bug, and is closely related in the interaction with requirements. (Fixes #991).
PR Checklist: