Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Android font support for text widgets (Label, NumberInput, TextInput) including bold & italic & font size.
This does not add fantasy or cursive support. Those are a smidge more complicated, and I'd prefer to add those in a separate pull request.
Screenshot of TravelTips now:
Feedback welcome.
Implementation choices
Sometimes, calls to Android
measure()
will throwNullPointerException
. For some widgets, they needLayoutParams
(which are only added in Toga when a widget gets added to a container) beforemeasure()
can be called. This does an explicit check forNone
in those cases, which does the job fine, so I propose we roll with it.PR Checklist: