[widget audit] toga.Switch #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
commented
Mar 29, 2023
| # Allow a class with no new methods to be defined by assigning | ||
| # from an existing class. The col_offset means we only pay | ||
| # attention to assignments at the top level of a module, not | ||
| # assignments inside method bodies. |
There was a problem hiding this comment.
This line was catching the old_value = self._get_value('value') call in the dummy implementation. The line is required to allow for MainWindow = Window as a top level module assignment to be sufficient to define the existence of an interface class. This isn't a great check - but as soon as we're at 100% testbed coverage, we're not going to need the implementation checks anyway, so I figured a bandaid solution was sufficient.
freakboy3742
commented
Mar 29, 2023
gtk/tests/widgets/test_switch.py
Outdated
There was a problem hiding this comment.
The tests in this module are superseded by the testbed coverage.
10 tasks
mhsmith
reviewed
Apr 3, 2023
mhsmith
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a rework of the base
enabledflag. This was required because Switch on iOS and GTK is a composite widget, so determination of enabled status requires a different implementation.Audit checklist