Assume undefined icons to be None (GTK) #2024
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just checking if the row has an icon, the new proposed conditional checks if the "icon" attribute is a member of the row at all, then checks if the "icon" attribute is
None
. The code is also slightly refactored asif not hasattr...
is not as readable (to me) asgetattr(...) is not None
Previously, without setting a row's icon either explicitly, an error was thrown because
getattr(row, "icon")
is looking for an attribute that wasn't provided. After this change, when rows are defined without the icon attribute, the rows render without an icon and the code doesn't throw an error. This is only for GTK's implementation. (My first ever pull request, I wanted to start small :)PR Checklist:
(NA) All new features have been documented