Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations, minor cleanups #2044

Merged
merged 35 commits into from
Jul 26, 2023
Merged

Add type annotations, minor cleanups #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
144d479
Unify ID creation
NMertsch Jul 22, 2023
5ee6e63
Unify ID property documentation/annotation
NMertsch Jul 22, 2023
1f21932
Remove property return docstrings
NMertsch Jul 22, 2023
8cd65a2
sources.accessors: Add type annotations
NMertsch Jul 22, 2023
dfd744c
LengthBetween validator: fix type annotations (min/max lengths can be…
NMertsch Jul 22, 2023
0588b83
icons: Add type annotations
NMertsch Jul 22, 2023
4c8476e
fonts: Add type annotations
NMertsch Jul 22, 2023
9c90cdf
box: Add type annotations
NMertsch Jul 22, 2023
0db1c65
button: Add type annotations, fix #2042
NMertsch Jul 22, 2023
4e20d38
widget: Add/fix type annotations
NMertsch Jul 22, 2023
77bd181
app, window: Add/fix type annotations
NMertsch Jul 22, 2023
29d2892
Include py.typed file
NMertsch Jul 23, 2023
bf1a0b7
App callback protocols for app, button, and window
NMertsch Jul 23, 2023
afc2263
Remove redundant type information in docstrings
NMertsch Jul 23, 2023
edde3c9
Canvas: add type annotations
NMertsch Jul 23, 2023
9960fa7
Fix typos
NMertsch Jul 23, 2023
b96aa59
Replace typing.Optional with pipe-style unions
NMertsch Jul 23, 2023
f169fc9
Replace typing.Union with pipe-style unions
NMertsch Jul 23, 2023
46d9ce7
Window: add type annotations to dialog methods
NMertsch Jul 23, 2023
3a8bb0f
Window: add type annotations to dialog methods
NMertsch Jul 23, 2023
28cdd94
Validators: add return type annotations
NMertsch Jul 23, 2023
18fa057
ActivityIndicator: add type annotations
NMertsch Jul 23, 2023
7c4c41a
Add annotation for MainWindow.on_close
NMertsch Jul 23, 2023
7b5ff67
Add annotation for Widget
NMertsch Jul 23, 2023
8d300d6
Add typing.overloads for Window.select_folder_dialog
NMertsch Jul 23, 2023
2af50d0
Fix typo
NMertsch Jul 23, 2023
1682acb
Docs: add protocols
NMertsch Jul 23, 2023
be4389f
Window: add overloads for multi-mode dialogs
NMertsch Jul 23, 2023
ef83105
Satisfy isort
NMertsch Jul 23, 2023
d13ed6e
Satisfy pre-commit (black, pyupgrade, ...)
NMertsch Jul 23, 2023
e382e0d
Add PR summary to changes/
NMertsch Jul 23, 2023
50254ce
Remove faulty docstring section
NMertsch Jul 23, 2023
e6ed10c
Callback protocols: document return values
NMertsch Jul 23, 2023
c9ece97
Merge branch 'main' into unify-id-creation
freakboy3742 Jul 23, 2023
0bf11fa
Minor naming and wording cleanups.
freakboy3742 Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2044.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Toga now has significantly improved type annotations for its public API
3 changes: 3 additions & 0 deletions core/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,16 @@ docs =
sphinx-autodoc-typehints == 1.22
sphinx-csv-filter == 0.4.1
sphinx-copybutton == 0.5.2
sphinx-toolbox == 3.4.0
sphinxcontrib-spelling == 7.7.0

[options.package_data]
toga.resources =
*.icns
*.ico
*.png
toga =
py.typed

[options.packages.find]
where = src
Loading
Loading