Feat web password #2089
Merged
Feat web password #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
approved these changes
Aug 21, 2023
freakboy3742
requested changes
Aug 21, 2023
There was a problem hiding this comment.
The CI failure is due to a missing towncrier file; see the contribution guide for details.
Once that's fixed, I'm happy to merge this as is; or I can wait until you've got the validation working as well.
freakboy3742
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a password input web backend component using Shoelace and allows the
sl-changeevent to trigger validation.See screenshot for the component in action.
Steps to test:
cd examples\passwordinputbriefcase run webPR Checklist: