Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macOS HIG compliance of Close and Close All menu items. #2217

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

freakboy3742
Copy link
Member

The menu items used for Close and Close All follow the example of Safari, which is a bit of an oddity when compared to most other macOS apps.

This PR changes the default macOS menu items to match the more common naming and shortcuts:

  • "Close Window" (CMD-SHIFT-W) -> "Close" (CMD-W)
  • "Close All Windows" (CMD-OPT-SHIFT-W) -> "Close" (CMD-OPT-W)

Fixes #2214.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first thought was that Close All is the same as Quit because we don't yet support running an app without any windows. But since people have it in their muscle memory, we should support it anyway.

@mhsmith mhsmith merged commit 3113b1e into beeware:main Nov 10, 2023
35 checks passed
@freakboy3742 freakboy3742 deleted the macos-close branch November 10, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cocoa Close Window shortcut is incorrect
2 participants