Updated macOS minimum version to 11, matching Briefcase #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Looks good; and bonus points for cleaning up the dead paths in appkit.py, not just updating the documentation.
Regarding the changenote - this is a removal. It's a backwards incompatible change that will (potentially) impact users; it gets phrased in terms of what was removed: "Support for macOS release prior to Big Sur (11) has been dropped."
Project-wide search sure is handy, isn't it? : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation to list minimum macOS version as 11 (Big Sur) rather than 10.10 (Yosemite). Also cleaned up places where Cocoa classes were commented out or conditionally defined due to lack of availability in older OS versions.
As mentioned here, Briefcase supports a minimum of 11 (Big Sur), so the documentation is misleading and the avoided / conditional Cocoa definitions are unnecessary.
Since #2227 is nowhere near as simple as I'd first thought, I'm putting this in separately rather than wait for resolution on that.
...What category should this changenote be? Docs? It does change code, but doesn't actually fix a bug.
PR Checklist: