New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct issues with event handlers and app startup in Textual backend #2267

Merged

mhsmith merged 4 commits into beeware:main from freakboy3742:textual-fixes

Dec 10, 2023

Member

freakboy3742 commented Dec 9, 2023 •

edited

Loading

Some of the changes made late in 0.3.X development weren't fully reflected in the Textual backend. This corrects those oversights.

The App impl needs to explicitly set the reference to self on the interface
Event handlers no longer need the initial "self" argument
Textual now appears to use title as a protected attribute on modal screens.
The name change of the multiselect argument on file dialogs has been made.

PR Checklist:

All new features have been tested
All new features have been documented
I have read the CONTRIBUTING.md file
I will abide by the code of conduct

freakboy3742 added 4 commits

December 9, 2023 08:35


          Correct issues with event handlers and app startup.

0b78dc7


          Add changenote.

d616d06


          More API regressions.

1d3d272


          Set a minimum textual version.

34c3849

freakboy3742 requested a review from mhsmith

December 9, 2023 01:38

mhsmith approved these changes

View reviewed changes

mhsmith merged commit a87c89c into beeware:main

35 checks passed

freakboy3742 deleted the textual-fixes branch

December 10, 2023 22:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet