-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WebKit2 dependencies #2545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I added a few notes/corrections in line.
Co-authored-by: Russell Martin <russell@rjm.li>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good deal. I saw some additional opportunities to add details for OpenSUSE and align the specific list of reqs across the distros...but that seemed out of scope here. 👍🏼
Updates the unix pre-requisites to accomodate the WebKit2 package changes, primarily for the benefit of Ubuntu 24.04.
WebKit2 has been removed from the general Linux requirements list, in favor of a base set of packages plus an explicit list of system requirements on widgets that require it. The error message raised when those system requirements can't be found now explicitly references the system requirements in the docs (although the anchor on the link won't be valid until a stable release is cut).
Fixes #2544.
PR Checklist: