Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Command attribute to text instead label #2605

Merged
merged 2 commits into from
May 27, 2024

Conversation

lipruhland
Copy link
Contributor

Probably something was left behind after the change

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Probably something was left behind after the change

Signed-off-by: Philip Ruhland <lipruhland@proton.me>
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

For future reference, the first pass at CI failed because the PR was missing a changenote; I've added one for you.

@freakboy3742 freakboy3742 merged commit 28ecfa7 into beeware:main May 27, 2024
31 of 34 checks passed
@lipruhland
Copy link
Contributor Author

Thanks for the fix!

For future reference, the first pass at CI failed because the PR was missing a changenote; I've added one for you.

Thank you for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants