Define application lifecycle events by subclassing #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mhsmith
reviewed
Jun 27, 2024
Co-authored-by: Malcolm Smith <smith@chaquo.com>
mhsmith
approved these changes
Jun 28, 2024
This was referenced Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on_exitso that it can be defined by subclassing, in addition to assigning anon_exitattributerunningentry point added by Add support for background and session-based apps #2651 to be namedon_running(reflecting it's status as a lifecycle event), following the same pattern ason_exit.app.add_background_task().Fixes #2099.
PR Checklist: