Speculative fix for intermittent Wayland issue. #2891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As another datapoint, this delay was my first strategy...but I didn't have any luck :/ |
Hrm... your original PR has collapsed all its commit history - I don't suppose you have any records of the specific change you made? In particular, did you do a |
|
I never actually pushed changes that included a delay because no matter how I incorporated a delay locally changed anything. In #2873, I was mostly just trying to confirm that none of the widgets had focus when the test failed in CI...which is what I was seeing locally. Also, FWIW, this is how I test locally: while true; do WAYLAND_DISPLAY=toga briefcase run --test -- tests/widgets/; sleep 3; doneI delete first Additional FWIW, it fails very often on my machine....so, slower machines like CI may be even less likely to experience this failure. |
Could I ask you to take the latest commit on this branch for a spin? It's takes a bit more of a persistent retry approach; if you've got a case that reproduces it (or, at least, more reliably reproduces it than CI), that would be helpful - I don't see it locally. |
|
failing currently
|
🤦 Save all the file before pushing, Russell... Try it now. |
|
🤣 no worries Got this on my 2nd or 3rd run: |
Whelp. And the first run in CI. This one is a doozy... |
|
Closing on the basis that #2893 fixes the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A speculative fix for the intermittent Wayland issue. Experimentally from #2873, the issue appears to be that no widget has focus as a result of the
other.focus()call; one theory is that due to the timing on some machines, the "other" widget isn't quite ready to receive focus. Add a short delay before assigning focus to test that theory.Fixes #2871.
PR Checklist: