Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

Multidestinations support #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dkhunt27
Copy link
Collaborator

Added Features:

  • subscribe/unsubscribe now can take an array of destinations
  • test coverage improved; some unit and integration tests (still more can be done here)
  • working example app demonstrating connect, disconnect, subscribe, and publish
  • updated docs to use jsduck
  • added make file for common commands

Breaking API Changes:

  • to create a client
  •  new: var Stomp = require('stomp'); var stompClient = new Stomp().Client(args);
    
  •  old: var stomp = require('stomp'); var stompClient = new stomp.Stomp(args);
    
  • to create a stomp utils (although this should be handled all internally)
  •  new: var StompUtils = require('./stomp.utils'); var stompUtils = new StompUtils();
    
  •  old: var stomp_utils = require('./stomp-utils'); var stompUtils = new stomp_utils.StompUtils();
    
  • to create a stomp logger (although this should be handled all internally)
  •  new: var StompLogger = require('./stomp.logger.js'); var log = new StompLogger(debug);
    
  •  old: var stomp_utils = require('./stomp-utils'); var log = new stomp_utils.StompLogging(debug);;
    

Other:

  • refactored using revealing module pattern
  • other OCD refactoring
  • jshint fixes
  • bumped version to 0.2.0

dkhunt27 added 2 commits July 24, 2013 18:11
…jshint fixes; added tests; updat

ed examples; updated readme for example app; switch documenation to jsduck; added make file for common commands
@benjaminws
Copy link
Owner

This is so great. I'm going to pull this down and look over things locally, but so far I have no complaints. I'll try to get this merged up ASAP.

Would you like to be a contributor on the project? Or have any interest in taking it over? I don't want it to die.

@dkhunt27
Copy link
Collaborator Author

dkhunt27 commented Aug 3, 2013

For sure, I would like to be a contributor. I would need to better understand the underlying frame/socket magic you did before taking it over if you are looking for someone to do that.

On another note, It appears that this is currently supporting STOMP 1.0. I think in the near future I would probably need STOMP 1.1 support (NACK). Have you looked into that at all?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants