OXAP-149 Added street parsing without the config of a country iso code #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3nl
force-pushed
the
features/make-street-handling-easier
branch
4 times, most recently
from
ebf59ce
to
2d0469e
Compare
- Fixed the wrong type hint for the parsing return - Refactored the parsing unit test to a data provider and fixture - Removed unused configuration - Made the switches for the relevant address parsing more speaking Signed-off-by: Bjoern Lange <bjoern.lange@bestit-online.de>
b3nl
force-pushed
the
features/make-street-handling-easier
branch
from
2d0469e
to
b29f5ce
Compare
|
Tests look good and code is backwards compatible with other tests and amazon itself says, it looks good. So i merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bjoern Lange bjoern.lange@bestit-online.de