Feature/oxap 292 refactor company handling #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3nl
force-pushed
the
feature/OXAP-292-refactor-company-handling
branch
from
fe8b8dd
to
78f6f12
Compare
b3nl
force-pushed
the
features/make-street-handling-easier
branch
from
2d0469e
to
b29f5ce
Compare
b3nl
force-pushed
the
feature/OXAP-292-refactor-company-handling
branch
3 times, most recently
from
00cb391
to
b683fc9
Compare
b3nl
changed the base branch from
features/make-street-handling-easier
to
develop
added 2 commits
October 10, 2019 12:38
…readable Signed-off-by: Bjoern Lange <bjoern.lange@bestit-online.de>
…g handling for the street number of amazon Signed-off-by: Bjoern Lange <bjoern.lange@bestit-online.de>
b3nl
force-pushed
the
feature/OXAP-292-refactor-company-handling
branch
from
b683fc9
to
301b6e6
Compare
|
Old Tests run still! New tests are added to map the original pseudo code of amazon and amazon itself says, that it looks good, so i will merge. But a small warning: This are text parsers. There could be another combination of strings which are not mapped yet. We simple can not match every possible combination with this data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.