Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAJ DSFR 1.12.1 / adaptation du code #4457

Merged
merged 11 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The application should be accessible at `localhost:8080`.

## System dependencies

Make sure `node` 16.x is installed on your machine:
Make sure `node` 18.x is installed on your machine:

### Ubuntu

Expand Down Expand Up @@ -166,6 +166,10 @@ There are several levels of tests:

You can safely use `npm test && npm run cypress` to drive your developments.

## Development Environment and Cypress

In Cypress tests, we verify that email functionality works. To check this locally, you need to copy and paste the environmental variables from .env.e2e to your .env file (and create the .env file if you don't already have one).

## Email

We use the framework [MJML](https://mjml.io/) to design and integrate the templates. [Tipimail](https://fr.tipimail.com) is our service to send emails.
Expand Down
15 changes: 4 additions & 11 deletions cypress/utils/results.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,17 +247,10 @@ const receiveResultsEmail = () => {
cy.get('[data-testid="simulation-id"')
.invoke("text")
.then((simulationId) => {
cy.url().then((url) => {
if (url.includes("localhost")) {
// skip this test on localhost
// todo : implement a solution for testing this feature locally
return
} else {
// Works on CI only
cy.task("getLastEmail", email)
.its("headers.subject")
.should("includes", simulationId)
}
cy.url().then(() => {
cy.task("getLastEmail", email)
.its("headers.subject")
.should("includes", simulationId)
})
})
}
Expand Down
Loading
Loading