Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HopSkipJump attack #574

Merged
merged 16 commits into from
Aug 29, 2020
Merged

Implement HopSkipJump attack #574

merged 16 commits into from
Aug 29, 2020

Conversation

zimmerrol
Copy link
Member

This PR implements the HopSkipJump attack as described in the paper. The code is based on the reference reference implementation.

There are still some test cases missing at the moment.

@coveralls
Copy link

coveralls commented Aug 10, 2020

Coverage Status

Coverage increased (+57.1%) to 95.247% when pulling 863fc03 on zimmerrol:hsja into 8394996 on bethgelab:master.

@jonasrauber
Copy link
Member

What’s the status of this?

Could you explain why this attack requires a separate attack-specific test file?
Maybe we should add a comment in the file to document this reason.

@zimmerrol
Copy link
Member Author

@jonasrauber The attack is implemented and seems to work. However, the tests are still taking a lot of time (especially for the TF backend)... Regarding the attack-specific test file: this attack needs a separate test file for the same reasons the Brendel Bethge attack does: the attack uses another attack at the beginning to find the initial adversarial perturbations; next, the attack tries to minimize the perturbation while keeping it adversarial. Thus, we cannot just use the other test file that only checks whether the final result is adversarial but we have to verify that the magnitude of the perturbation was decreased to validate the attack's behavior. Does this make sense to you?

@jonasrauber jonasrauber merged commit 5f0e12f into bethgelab:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants