Fix runtime dependencies #190

y-yagi · 2023-11-14T00:50:05Z

What? Why?

It seems that unsued gems are defined in runtime_dependency. This PR did the following.

$ git grep thwait
Gemfile:gem 'thwait', '>= 0.1'
spec/gruf/synchronized_client_spec.rb:require 'thwait'

Remove e2mmap from runtime_dependency. This gem was added by f157736, but it seems isn't used now.

I confirmed that the specs are passed.

splittingred · 2023-11-28T22:45:25Z

Hi, thanks for this! Can you add a note to CHANGELOG.md describing this change? Thanks!

y-yagi · 2023-11-28T23:10:21Z

@splittingred
Thanks for your comment! I added a CHANGELOG entry.

splittingred · 2024-02-15T19:03:13Z

Hi @y-yagi - can you rebase from latest?

This gem was added by f157736, but it seems isn't used now.

y-yagi · 2024-02-15T21:03:23Z

y-yagi force-pushed the fix-runtime_dependencies branch 3 times, most recently from f89429b to bb94dad Compare December 12, 2023 03:54

y-yagi added 3 commits February 16, 2024 06:02

Remove thwait from runtime_dependency that only used in tests

c6deb6a

Remove e2mmap from runtime_dependency

460859f

This gem was added by f157736, but it seems isn't used now.

Add a CHANGELOG entry

0d02e31

y-yagi force-pushed the fix-runtime_dependencies branch from bb94dad to 0d02e31 Compare February 15, 2024 21:02

splittingred approved these changes Feb 15, 2024

View reviewed changes

splittingred merged commit f40f022 into bigcommerce:main Feb 15, 2024
17 checks passed

y-yagi deleted the fix-runtime_dependencies branch February 16, 2024 08:16