Fix IE11 incompatibilities (#2408)

bigskysoftware · Mar 21, 2024 · e64238d · e64238d · Telroshan · Apr 12, 2024
1 parent 9b1e9bc
commit e64238d
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 7 deletions.
diff --git a/src/htmx.js b/src/htmx.js
@@ -138,12 +138,12 @@ return (function () {
 
         /**
          * @param {string} tag
-         * @param {boolean} global
+         * @param {boolean} [global]
          * @returns {RegExp}
          */
-        function makeTagRegEx(tag, global = false) {
-            return new RegExp(`<${tag}(\\s[^>]*>|>)([\\s\\S]*?)<\\/${tag}>`,
-                global ? 'gim' : 'im');
+        function makeTagRegEx(tag, global) {
+          return new RegExp('<' + tag + '(\\s[^>]*>|>)([\\s\\S]*?)<\\/' + tag + '>',
+            !!global ? 'gim' : 'im')
         }
 
         function parseInterval(str) {
@@ -1945,6 +1945,9 @@ return (function () {
 
         function shouldProcessHxOn(elt) {
             var attributes = elt.attributes
+            if (!attributes) {
+                return false
+            }
             for (var j = 0; j < attributes.length; j++) {
                 var attrName = attributes[j].name
                 if (startsWith(attrName, "hx-on:") || startsWith(attrName, "data-hx-on:") ||
@@ -1967,11 +1970,11 @@ return (function () {
                 var iter = document.evaluate('.//*[@*[ starts-with(name(), "hx-on:") or starts-with(name(), "data-hx-on:") or' +
                                                                            ' starts-with(name(), "hx-on-") or starts-with(name(), "data-hx-on-") ]]', elt)
                 while (node = iter.iterateNext()) elements.push(node)
-            } else {
+            } else if (typeof elt.getElementsByTagName === "function") {
                 var allElements = elt.getElementsByTagName("*")
                 for (var i = 0; i < allElements.length; i++) {
-                    if (shouldProcessHxOn(allElements[i])) {
-                        elements.push(allElements[i])
+                  if (shouldProcessHxOn(allElements[i])) {
+                      elements.push(allElements[i])
                     }
                 }
             }

diff --git a/test/core/ajax.js b/test/core/ajax.js
@@ -1237,6 +1237,11 @@ describe("Core htmx AJAX Tests", function(){
     })
 
     it('properly handles inputs external to form', function () {
+        if (!supportsFormAttribute()) {
+            this._runnable.title += " - Skipped as IE11 doesn't support form attribute"
+            this.skip()
+            return
+        }
         var values;
         this.server.respondWith("Post", "/test", function (xhr) {
             values = getParameters(xhr);
@@ -1287,6 +1292,11 @@ describe("Core htmx AJAX Tests", function(){
     })
 
     it("can associate submit buttons from outside a form with the current version of the form after swap", function(){
+        if (!supportsFormAttribute()) {
+            this._runnable.title += " - Skipped as IE11 doesn't support form attribute"
+            this.skip()
+            return
+        }
         const template = '<form ' +
               'id="hello" ' +
               'hx-target="#hello" ' +

diff --git a/test/core/regressions.js b/test/core/regressions.js
@@ -246,6 +246,11 @@ describe("Core htmx Regression Tests", function(){
     })
 
     it("script tags only execute once using templates", function(done) {
+        if (!supportsTemplates()) {
+            this._runnable.title += " - Skipped as IE11 doesn't support templates"
+            this.skip()
+            return
+        }
         var oldUseTemplateFragmentsValue = htmx.config.useTemplateFragments
         htmx.config.useTemplateFragments = true
 
@@ -267,6 +272,11 @@ describe("Core htmx Regression Tests", function(){
     })
 
     it("script tags only execute once when nested using templates", function(done) {
+        if (!supportsTemplates()) {
+            this._runnable.title += " - Skipped as IE11 doesn't support templates"
+            this.skip()
+            return
+        }
         var oldUseTemplateFragmentsValue = htmx.config.useTemplateFragments
         htmx.config.useTemplateFragments = true