Annotation shortcut #935
Merged
Annotation shortcut #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the capability of toggling the creation an annotation with Enter when doing measurements. Since this could cause Biigle to bug when using it without having closed the annotation, a new info message is instroduced when trying to do that.
When using other buttons and measuring, the function convertMeasurement gets triggered. This caused the error message to get triggered.
mzur
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Mostly fine, thanks! Only three comments:
- Instead of showing a notification that the line should be finished, I would simply disable/ignore the keyboard shortcut until the measurement line was finished (similar to the "convert" button being disabled then).
- Please add the new shortcut to the manual (here, maybe add a new section at the bottom).
- The video annotation tool doesn't have a measure tool at all, so no changes are required here.
…s not closed As per review, removes the error message
Gotcha, should be fixed now! |
mzur
reviewed
Oct 7, 2024
resources/views/manual/tutorials/annotations/shortcuts.blade.php
Outdated
Show resolved
Hide resolved
resources/assets/js/annotations/components/annotationCanvas/measureInteraction.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #475 ; adds a shortcut with Enter when using the ruler / measurement tool to add an annotation.
To test this, try and use the line measurement tool and create an annotation with Enter after having closed the interested area. Please check that this addition does not interfere with other parts of the project (e.g. conflict with other keyboard shortcuts. I checked, and I should have fixed the only problem I found, which was when pressing enter with other instruments)