Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-nested-ternary #4067

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Sep 24, 2024

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Sep 24, 2024
Copy link

codspeed-hq bot commented Sep 24, 2024

CodSpeed Performance Report

Merging #4067 will degrade performances by 6.77%

Comparing kaykdm:no-nested-ternary (5bf0f08) with main (ecf1f16)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 105 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kaykdm:no-nested-ternary Change
pure_9395922602181450299.css[uncached] 3.9 ms 4.2 ms -6.77%
react.production.min_3378072959512366797.js[uncached] 2.2 ms 2.1 ms +6.21%

@dyc3 dyc3 merged commit d03c6cd into biomejs:main Sep 25, 2024
11 of 12 checks passed
@kaykdm kaykdm deleted the no-nested-ternary branch September 25, 2024 13:38
@Conaclos Conaclos added the A-Changelog Area: changelog label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants