-
Notifications
You must be signed in to change notification settings - Fork 130
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add graph package * Add dag validation * Bump format version * Update error messages * Use different sorting * Update test
- Loading branch information
Showing
55 changed files
with
4,828 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,202 @@ | ||
| package cli | ||
|
|
||
| import ( | ||
| "encoding/base64" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| const validStagedPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| staged: | ||
| stages: | ||
| - s1: {} | ||
| - s2: {} | ||
| - s3: {} | ||
| stages: | ||
| s1: | ||
| workflows: | ||
| - a: {} | ||
| s2: | ||
| workflows: | ||
| - b: {} | ||
| - c: {} | ||
| - d: {} | ||
| s3: | ||
| workflows: | ||
| - e: {} | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| c: {} | ||
| d: {} | ||
| e: {} | ||
| ` | ||
|
|
||
| const validDAGPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| a: {} | ||
| b: { depends_on: [a] } | ||
| c: { depends_on: [a] } | ||
| d: { depends_on: [a] } | ||
| e: { depends_on: [b, d] } | ||
| f: { depends_on: [e] } | ||
| g: { depends_on: [a, e, f] } | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| c: {} | ||
| d: {} | ||
| e: {} | ||
| f: {} | ||
| g: {} | ||
| ` | ||
|
|
||
| const mixedStagedAndDAGPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| a: {} | ||
| b: { depends_on: [a] } | ||
| stages: | ||
| - stage1: {} | ||
| stages: | ||
| stage1: | ||
| workflows: | ||
| - a: {} | ||
| - b: {} | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| ` | ||
|
|
||
| const missingWorkflowInDAGPipelineDefinition = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| a: {} | ||
| b: { depends_on: [c] } | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| c: {} | ||
| ` | ||
|
|
||
| const missingWorkflowInWorkflowDefinitionForDAGPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| a: {} | ||
| b: { depends_on: [c] } | ||
| c: {} | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| ` | ||
|
|
||
| const duplicatedDependencyDAGPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| a: {} | ||
| b: { depends_on: [a, a] } | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| ` | ||
|
|
||
| const utilityWorkflowDAGPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| _a: {} | ||
| b: { depends_on: [_a] } | ||
| workflows: | ||
| _a: {} | ||
| b: {} | ||
| ` | ||
|
|
||
| const cycleInDAGPipeline = ` | ||
| format_version: '13' | ||
| pipelines: | ||
| dag: | ||
| workflows: | ||
| a: {} | ||
| b: { depends_on: [c] } | ||
| c: { depends_on: [b] } | ||
| workflows: | ||
| a: {} | ||
| b: {} | ||
| c: {} | ||
| ` | ||
|
|
||
| func TestValidation(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| config string | ||
| wantErr string | ||
| }{ | ||
| { | ||
| name: "Mixing stages and workflows in the same pipeline", | ||
| config: mixedStagedAndDAGPipeline, | ||
| wantErr: "Failed to get config (bitrise.yml) from base 64 data, err: Failed to parse bitrise config, error: pipeline (dag) has both stages and workflows", | ||
| }, | ||
| { | ||
| name: "Workflow is missing from the DAG pipeline definition", | ||
| config: missingWorkflowInDAGPipelineDefinition, | ||
| wantErr: "Failed to get config (bitrise.yml) from base 64 data, err: Failed to parse bitrise config, error: workflow (c) defined in dependencies (b) is not part of pipeline (dag)", | ||
| }, | ||
| { | ||
| name: "Workflow is missing from the Workflow definition", | ||
| config: missingWorkflowInWorkflowDefinitionForDAGPipeline, | ||
| wantErr: "Failed to get config (bitrise.yml) from base 64 data, err: Failed to parse bitrise config, error: workflow (c) defined in pipeline (dag) is not found in the workflow definitions", | ||
| }, | ||
| { | ||
| name: "Utility workflow is referenced in the DAG pipeline", | ||
| config: utilityWorkflowDAGPipeline, | ||
| wantErr: "Failed to get config (bitrise.yml) from base 64 data, err: Failed to parse bitrise config, error: workflow (_a) defined in pipeline (dag) is a utility workflow", | ||
| }, | ||
| { | ||
| name: "Duplicated dependency in the DAG pipeline", | ||
| config: duplicatedDependencyDAGPipeline, | ||
| wantErr: "Failed to get config (bitrise.yml) from base 64 data, err: Failed to parse bitrise config, error: workflow (a) is duplicated in the dependency list (b)", | ||
| }, | ||
| { | ||
| name: "Cycle in the DAG pipeline", | ||
| config: cycleInDAGPipeline, | ||
| wantErr: "Failed to get config (bitrise.yml) from base 64 data, err: Failed to parse bitrise config, error: the dependency between workflow 'b' and workflow 'c' creates a cycle in the graph", | ||
| }, | ||
| { | ||
| name: "Valid DAG pipeline", | ||
| config: validDAGPipeline, | ||
| wantErr: "", | ||
| }, | ||
| { | ||
| name: "Valid staged pipeline", | ||
| config: validStagedPipeline, | ||
| wantErr: "", | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| b64Data := base64.StdEncoding.EncodeToString([]byte(tt.config)) | ||
| _, _, err := CreateBitriseConfigFromCLIParams(b64Data, "") | ||
|
|
||
| if tt.wantErr != "" { | ||
| require.EqualError(t, err, tt.wantErr) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.