Clean up activator #981
Merged
Clean up activator #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Jul 5, 2024
| ymlPth = origStepYMLPth | ||
| } | ||
| err = fmt.Errorf("failed to parse step definition (%s): %s", ymlPth, err) | ||
| err = fmt.Errorf("parse step.yml of '%s': %s", stepIDData.IDorURI, err) |
There was a problem hiding this comment.
I think in case of path:: step references it's enough to print the reference, it's a relative path to a file I have access to anyway. I don't think it's worth creating a leaky abstraction (in the ActivatedStep struct) just to print this local file path.
This was referenced Jul 5, 2024
tothszabi
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
#973
Cleaning up the refactored code paths
Changes
Investigation details
Decisions