Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11438] add padding to self-hosted subscription import button #10869

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Sep 3, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11438

📔 Objective

This PR adds padding to the import button in the self-hosted subscription page.

📸 Screenshots

Admin Controls

Before After
Screenshot 2024-09-03 at 4 24 42 PM Screenshot 2024-09-04 at 10 36 48 AM

Password manager

Before After
Screenshot 2024-09-04 at 11 02 28 AM Screenshot 2024-09-04 at 11 02 07 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.28%. Comparing base (74d5103) to head (fa52d8c).
Report is 59 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10869      +/-   ##
==========================================
+ Coverage   33.06%   36.28%   +3.22%     
==========================================
  Files        2680     2695      +15     
  Lines       83318    87977    +4659     
  Branches    15843    17407    +1564     
==========================================
+ Hits        27546    31920    +4374     
- Misses      53595    54965    +1370     
+ Partials     2177     1092    -1085     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Logo
Checkmarx One – Scan Summary & Details86c021f6-50fc-4197-ad26-c2e13ee0430f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 469 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/connectors/webauthn-fallback.ts: 116 Attack Vector
LOW Client_JQuery_Deprecated_Symbols /libs/importer/src/services/import.service.ts: 455 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html: 1

@danielleflinn
Copy link
Member

@jaasen-livefront can you also include a screenshot of how this looks with the styles from the #8696 branch applied since that is where the bug was found?

@jaasen-livefront
Copy link
Collaborator Author

@jaasen-livefront can you also include a screenshot of how this looks with the styles from the #8696 branch applied since that is where the bug was found?

@danielleflinn Done!

@danielleflinn
Copy link
Member

danielleflinn commented Sep 4, 2024

@jaasen-livefront it looks slightly larger than the screenshot in the jira. Can you try to match the top/bottom padding with the padding left of the button?

Also, for individual users can you make the same change on the Settings / Subscription page?
Screenshot 2024-09-04 at 10 24 11 AM

@jaasen-livefront
Copy link
Collaborator Author

jaasen-livefront commented Sep 4, 2024

@jaasen-livefront it looks slightly larger than the screenshot in the jira. Can you try to match the top/bottom padding with the padding left of the button?

Also, for individual users can you make the same change on the Settings / Subscription page?

@danielleflinn Done and done!

danielleflinn
danielleflinn previously approved these changes Sep 4, 2024
@jaasen-livefront jaasen-livefront removed the request for review from djsmith85 September 4, 2024 18:34
@jaasen-livefront
Copy link
Collaborator Author

@danielleflinn @cturnbull-bitwarden Would you mind re-approving? I merged main and GH dismissed your previous approvals.

@jaasen-livefront jaasen-livefront merged commit 329f8b1 into main Sep 5, 2024
35 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-11438 branch September 5, 2024 16:32
cagonzalezcs pushed a commit that referenced this pull request Sep 5, 2024
)

* add padding to import button

* reduce padding on upload input

* add padding to premium self-hosted file upload
@jaasen-livefront jaasen-livefront restored the PM-11438 branch September 10, 2024 22:38
@jaasen-livefront jaasen-livefront deleted the PM-11438 branch September 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants