-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11438] add padding to self-hosted subscription import button #10869
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10869 +/- ##
==========================================
+ Coverage 33.06% 36.28% +3.22%
==========================================
Files 2680 2695 +15
Lines 83318 87977 +4659
Branches 15843 17407 +1564
==========================================
+ Hits 27546 31920 +4374
- Misses 53595 54965 +1370
+ Partials 2177 1092 -1085 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
@jaasen-livefront can you also include a screenshot of how this looks with the styles from the #8696 branch applied since that is where the bug was found? |
@danielleflinn Done! |
@jaasen-livefront it looks slightly larger than the screenshot in the jira. Can you try to match the top/bottom padding with the padding left of the button? Also, for individual users can you make the same change on the Settings / Subscription page? |
@danielleflinn Done and done! |
fa52d8c
@danielleflinn @cturnbull-bitwarden Would you mind re-approving? I merged main and GH dismissed your previous approvals. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11438
📔 Objective
This PR adds padding to the import button in the self-hosted subscription page.
📸 Screenshots
Admin Controls
Password manager
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes