[CL-396] Update theme colors to new hexes #10968
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## ps/extension-refresh #10968 +/- ##
========================================================
+ Coverage 33.07% 35.05% +1.97%
========================================================
Files 2680 2680
Lines 83427 83427
Branches 15858 15858
========================================================
+ Hits 27595 29245 +1650
+ Misses 53646 53212 -434
+ Partials 2186 970 -1216 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| @@ -9,36 +9,39 @@ | |||
| --color-background-alt3: 18 82 163; | |||
| --color-background-alt4: 13 60 119; | |||
|
|
|||
There was a problem hiding this comment.
Not sure if I missed this or if we missed it in the last color update but in Figma I have the following for background-alt:
background-alt=243, 246, 249
libs/components/src/tw-theme.css
Outdated
| --color-warning-600: 255 191 0; | ||
| --color-warning-700: 255 248 228; | ||
|
|
||
| --color-info-100: 26 66 172; |
| --color-warning-100: 87 52 0; | ||
| --color-warning-600: 255 187 87; | ||
| --color-warning-700: 255 207 138; | ||
| --color-warning-100: 172 88 0; |
There was a problem hiding this comment.
Wow I wasn't even close.....
There was a problem hiding this comment.
Wait, danger or warning?
There was a problem hiding this comment.
Dark theme danger; idk how the comment ended up on warning 😬 You hadn't changed danger-700 at all so maybe Github cropped out the line?
There was a problem hiding this comment.
just to clarify danger -> warning and warning -> info right?
There was a problem hiding this comment.
No, the variable names aren't changing, she just commented on the wrong line and we were confused 😂
🎟️ Tracking
CL-396
📔 Objective
This PR updates the base color palette as per the most recent colors from design.
📸 Screenshots
Check Storybook for changes (recommend the Colors page and the Kitchen Sink).
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes