-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL-237] Update menu styles for extension refresh #9525
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ps/extension-refresh #9525 +/- ##
========================================================
+ Coverage 28.05% 28.09% +0.04%
========================================================
Files 2394 2383 -11
Lines 70557 70436 -121
Branches 13211 13205 -6
========================================================
- Hits 19792 19790 -2
+ Misses 49194 49079 -115
+ Partials 1571 1567 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the padding in Figma is slightly different than what we have here. Can we update these?
- .375rem top + bottom padding, menu item
- .75rem left + right padding, menu item
- .25rem top + bottom padding, menu container
Also looks like the border color was updated to secondary-600 back when we renamed things and in Figma we are still using the 500 variant for interactive borders...this might be something we want to address in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated padding and border looks great!
I found one more odd behavior with the keyboard navigation. When navigating the menu with arrow keys you have to select the down arrow 2 times to get the focus past the disabled item. This felt unexpected to me, so if possible it would nice if we could just skip the disabled item as if it were not present in the UI. Is that possible
🎟️ Tracking
CL-237
📔 Objective
This PR updates the styles of the
bit-menu
component to align with the new design system. It also addresses an issue where thebit-chip-select
was not showing the focus ring properly.📸 Screenshots
Check the Storybook Publish action, and view the Menu and Chip Select stories.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes