Network Caching System + Octokit Version Upgrade + Node 18 Upgrade #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bldrs-share-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Heya, just checking that this is paused pending the new etag caching? |
This was referenced May 30, 2024
…18 + add node-fetch
nickcastel50
changed the title
pablo-mayrgundter
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies #1166
This PR adds a full network caching system using etags. This ended up being a bit long-winded, because there is a bug in OctoKit where, when using the If-None-Match header and passing an etag, if we are not logged in OctoKit has a bug when returning the response and will crash. Bug is here: octokit/request.js#659
Because of this, I updated to the latest OctoKit which fixed the issue. The caveat here is I also had to upgrade us to Node 18 to use the latest OctoKit, which means we should thoroughly test this before deployment. The latest OctoKit also does not have a native fetch function anymore, so node-fetch was installed as a dev dependency in order to get the jest tests working again, as the GitHub specific tests were failing.