Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open GitHub link valid link doesnt activate open button #1252

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Aug 6, 2024

This PR:

  1. Adds an activate button for the search component in place of the clear input button.
  2. Adds a callBack parameter to the SearchBar component.
  3. Adds clearInput parameter to the SearchBar component to clear the input of the textBox when the OpenDialog is activated.
  4. Adds a useEffect to SearchBar to clear search input and query parameters when the the OpenDialog is activated.
  5. Triggers the callBack in SearchBar to close a dialog when the model is loaded using the Open dialog input box.

Tests:

Percy

@OlegMoshkovich OlegMoshkovich added the bug Something isn't working label Aug 6, 2024
@OlegMoshkovich OlegMoshkovich self-assigned this Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit e755b30
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/66ba1e1e24d30d0008894da5
😎 Deploy Preview https://deploy-preview-1252--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit e755b30
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/66ba1e1e3fdc4b0008f9e227
😎 Deploy Preview https://deploy-preview-1252--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…vate-open-button

Signed-off-by: OlegMoshkovich <oleg.mosh@gmail.com>
…vate-open-button

Signed-off-by: OlegMoshkovich <oleg.mosh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Open > GitHub > link: valid link doesn't activate open button
1 participant