Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide facility for retrieving all cookies; a wildcard CookieAccessInfo #24

Closed
keithamus opened this issue Feb 23, 2016 · 1 comment
Closed

Comments

@keithamus
Copy link
Contributor

Hey @bmeck, thanks for the awesome project! We use it inside of the chai-http plugin and it works great!

One thing that would be really useful for our users - given that chai-http is a test framework - is to get cookies irrespective of access settings (See this issue for more). Perhaps having a sentinel of Cookie.CookieAccessInfo.All could be used to flag to cookie.match() to automatically return true?

Any thoughts on this would be much appreciated. If you like the idea I'm happy to PR it 😄

@bmeck
Copy link
Owner

bmeck commented Feb 23, 2016

this seems pretty sane to me. just make a PR with a test.

keithamus added a commit to keithamus/node-cookiejar that referenced this issue Jun 13, 2016
This allows for fetching cookies with any access info, useful for tests.

Fixes bmeck#24
keithamus added a commit to keithamus/node-cookiejar that referenced this issue Jul 12, 2016
This allows for fetching cookies with any access info, useful for tests.

Fixes bmeck#24
@bmeck bmeck closed this as completed in #25 Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants