fix: make the file writing to be idempotent #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryTong65
reviewed
Aug 19, 2024
syncer/syncer.go
Outdated
| @@ -111,6 +111,7 @@ func (s *BlobSyncer) StartLoop() { | |||
| for range syncTicker.C { | |||
| if err = s.sync(); err != nil { | |||
| logging.Logger.Errorf("failed to sync, err=%s", err.Error()) | |||
| time.Sleep(2 * time.Second) | |||
There was a problem hiding this comment.
time.Sleep(2 * time.Second)
can you make it as a variable like xxxPauseTime
syncer/syncer.go
Outdated
| @@ -119,6 +120,7 @@ func (s *BlobSyncer) StartLoop() { | |||
| for range verifyTicket.C { | |||
| if err := s.verify(); err != nil { | |||
| logging.Logger.Errorf("failed to verify, err=%s", err.Error()) | |||
| time.Sleep(2 * time.Second) | |||
BarryTong65
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make the file writing to be idempotent. Blob dir will be deleted after finalising a bundle a the finalising height , but retry would happen on the same block in the case writing state to DB failed.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: