feat: fix review comments of sp exit #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
force-pushed
the
sp_exit_fix_comments
branch
from
19a360f
to
f72e1ab
Compare
unclezoro
approved these changes
Jul 6, 2023
fynnss
added a commit
that referenced
this pull request
Jul 7, 2023
* init virtual group module * add create/delete/deposit/withdraw/swapout messages * add sp keeper dependency * add router and type function * refactor sequence to support uint32 and U256 * impl virtual group module * refactor storage module * refactor challenge module to algin the new design * self review code * fix testcase and punish code * fix challenge testcases * refactor payment module to algin the new design * add e2e test * fix some unit tests * update cosmos-sdk * update go mod * fix e2e test * store deposit * update gomod * fix some e2e test case * fix cancel create object * ignore error for testing * fix storage test * fix test case * make GetGVG more simple * add virtual group swap out message * fix swap out * add event * fix ignite missing placeholder * add sp exit message * add sp exit * complete sp exit * add swap deposit * remove virtual payment account from local virtual group/ event * complete sp exit process * fix mock file error * add mock gen * fix swap out as secondary sp error * refator payment * refactor approval to get more extends * fix payment unit test * add withdraw cli * revert extends of approval * refactor payment for settlement and resume * refactor payment for out flow * fix proto * add basic migration bucket logic * fix the sp exit * refine the code * add payment for bucket migration * refactor code * fix some issues * fix issue and unit tests * add migration check and rebinding * refine the code * refactor withdraw from gvg & gvg family * feat: use bls sig in sealObject by secondary sps (#283) * fix gensp test error * add more check and params * add some unit tests for payment * fix compile error * add exit,completeexit, swapout events * add migration event * add create gvg family event * mirror update * fix lint issues * fix lint issues * fix some unit tests * fix the limit of gvgs and lvgs * fix bucket migration * fix address issues for new messages * refine challenge module * refine payment module * fix basesuite for create so many families * fix lint * add deposit/withdraw test for virtual group * fix issue of iterator * add basic sp exit test and fix some bugs * fix issue and refactor e2e tests * add e2e test cases * fix and add e2e test cases * refactor e2e test * add sp swap out test * refine code by cr * fix some review comments * fix cr suggestion * fix some review comments * refine the code * calculate sp num instead of constant * add migration e2e test * feat: bls sig for complete migrate bucket (#291) * fix bucket migration issue * update cosmos sdk version * fix migration bucket e2e test * fix CodeReview issues * fix some bugs * update staking per GB * refine some var * fix RebindingGVGsToBucket revert error * feat: Local virtual group and Billing info refacot (#306) * fix challenge refactor * fix some review tips * fix internal bucket info error * add family id to CreateBucketEvent * refactor challenge module * refactor payment module * fix redundany GenId * add family id check * refactor payment module * fix error * refactor payment module * fix issue * implement virtual group cmd * refine the comments of protobuf * fix e2e test * remove some useless code * fix sp exit test * add more sp exit test and fix some bugs * using id instead of address for some interfaces and events * fix some tests * fix e2e * fix unit test * add more check and parmas check * fix e2e tests * fix an issue * fix sp test * fix ci lint * remove useless code (#308) * chore: refine payment for gvg settle (#309) * chore: refine gvg staking per bytes and default params (#310) * rename gvgstakingprice to gvgstakingperbytes * fix DefaultMaxStoreSizePerFamily * feat: add chainId to bls sign doc (#313) * add chainId to bls sign doc * get chain id from cosmos context * feat: refine swap out and migrate bucket (#311) * fix: update swagger (#317) * feat: enhance head object api (#321) * fix gnfd query api (#318) * feat: update challenge and stop serving for sp exit (#322) * feat: fix review comments of sp exit (#320) * fix code review tips (#325) * fix cosmos sdk version * fix e2e test case * fix review tips
fynnss
added a commit
that referenced
this pull request
Jul 11, 2023
* init virtual group module * add create/delete/deposit/withdraw/swapout messages * add sp keeper dependency * add router and type function * refactor sequence to support uint32 and U256 * impl virtual group module * refactor storage module * refactor challenge module to algin the new design * self review code * fix testcase and punish code * fix challenge testcases * refactor payment module to algin the new design * add e2e test * fix some unit tests * update cosmos-sdk * update go mod * fix e2e test * store deposit * update gomod * fix some e2e test case * fix cancel create object * ignore error for testing * fix storage test * fix test case * make GetGVG more simple * add virtual group swap out message * fix swap out * add event * fix ignite missing placeholder * add sp exit message * add sp exit * complete sp exit * add swap deposit * remove virtual payment account from local virtual group/ event * complete sp exit process * fix mock file error * add mock gen * fix swap out as secondary sp error * refator payment * refactor approval to get more extends * fix payment unit test * add withdraw cli * revert extends of approval * refactor payment for settlement and resume * refactor payment for out flow * fix proto * add basic migration bucket logic * fix the sp exit * refine the code * add payment for bucket migration * refactor code * fix some issues * fix issue and unit tests * add migration check and rebinding * refine the code * refactor withdraw from gvg & gvg family * feat: use bls sig in sealObject by secondary sps (#283) * fix gensp test error * add more check and params * add some unit tests for payment * fix compile error * add exit,completeexit, swapout events * add migration event * add create gvg family event * mirror update * fix lint issues * fix lint issues * fix some unit tests * fix the limit of gvgs and lvgs * fix bucket migration * fix address issues for new messages * refine challenge module * refine payment module * fix basesuite for create so many families * fix lint * add deposit/withdraw test for virtual group * fix issue of iterator * add basic sp exit test and fix some bugs * fix issue and refactor e2e tests * add e2e test cases * fix and add e2e test cases * refactor e2e test * add sp swap out test * refine code by cr * fix some review comments * fix cr suggestion * fix some review comments * refine the code * calculate sp num instead of constant * add migration e2e test * feat: bls sig for complete migrate bucket (#291) * fix bucket migration issue * update cosmos sdk version * fix migration bucket e2e test * fix CodeReview issues * fix some bugs * update staking per GB * refine some var * fix RebindingGVGsToBucket revert error * feat: Local virtual group and Billing info refacot (#306) * fix challenge refactor * fix some review tips * fix internal bucket info error * add family id to CreateBucketEvent * refactor challenge module * refactor payment module * fix redundany GenId * add family id check * refactor payment module * fix error * refactor payment module * fix issue * implement virtual group cmd * refine the comments of protobuf * fix e2e test * remove some useless code * fix sp exit test * add more sp exit test and fix some bugs * using id instead of address for some interfaces and events * fix some tests * fix e2e * fix unit test * add more check and parmas check * fix e2e tests * fix an issue * fix sp test * fix ci lint * remove useless code (#308) * chore: refine payment for gvg settle (#309) * chore: refine gvg staking per bytes and default params (#310) * rename gvgstakingprice to gvgstakingperbytes * fix DefaultMaxStoreSizePerFamily * feat: add chainId to bls sign doc (#313) * add chainId to bls sign doc * get chain id from cosmos context * feat: refine swap out and migrate bucket (#311) * fix: update swagger (#317) * feat: enhance head object api (#321) * fix gnfd query api (#318) * feat: update challenge and stop serving for sp exit (#322) * feat: fix review comments of sp exit (#320) * fix code review tips (#325) * fix cosmos sdk version * fix e2e test case * fix review tips
fynnss
added a commit
that referenced
this pull request
Jul 13, 2023
* init virtual group module * add create/delete/deposit/withdraw/swapout messages * add sp keeper dependency * add router and type function * refactor sequence to support uint32 and U256 * impl virtual group module * refactor storage module * refactor challenge module to algin the new design * self review code * fix testcase and punish code * fix challenge testcases * refactor payment module to algin the new design * add e2e test * fix some unit tests * update cosmos-sdk * update go mod * fix e2e test * store deposit * update gomod * fix some e2e test case * fix cancel create object * ignore error for testing * fix storage test * fix test case * make GetGVG more simple * add virtual group swap out message * fix swap out * add event * fix ignite missing placeholder * add sp exit message * add sp exit * complete sp exit * add swap deposit * remove virtual payment account from local virtual group/ event * complete sp exit process * fix mock file error * add mock gen * fix swap out as secondary sp error * refator payment * refactor approval to get more extends * fix payment unit test * add withdraw cli * revert extends of approval * refactor payment for settlement and resume * refactor payment for out flow * fix proto * add basic migration bucket logic * fix the sp exit * refine the code * add payment for bucket migration * refactor code * fix some issues * fix issue and unit tests * add migration check and rebinding * refine the code * refactor withdraw from gvg & gvg family * feat: use bls sig in sealObject by secondary sps (#283) * fix gensp test error * add more check and params * add some unit tests for payment * fix compile error * add exit,completeexit, swapout events * add migration event * add create gvg family event * mirror update * fix lint issues * fix lint issues * fix some unit tests * fix the limit of gvgs and lvgs * fix bucket migration * fix address issues for new messages * refine challenge module * refine payment module * fix basesuite for create so many families * fix lint * add deposit/withdraw test for virtual group * fix issue of iterator * add basic sp exit test and fix some bugs * fix issue and refactor e2e tests * add e2e test cases * fix and add e2e test cases * refactor e2e test * add sp swap out test * refine code by cr * fix some review comments * fix cr suggestion * fix some review comments * refine the code * calculate sp num instead of constant * add migration e2e test * feat: bls sig for complete migrate bucket (#291) * fix bucket migration issue * update cosmos sdk version * fix migration bucket e2e test * fix CodeReview issues * fix some bugs * update staking per GB * refine some var * fix RebindingGVGsToBucket revert error * feat: Local virtual group and Billing info refacot (#306) * fix challenge refactor * fix some review tips * fix internal bucket info error * add family id to CreateBucketEvent * refactor challenge module * refactor payment module * fix redundany GenId * add family id check * refactor payment module * fix error * refactor payment module * fix issue * implement virtual group cmd * refine the comments of protobuf * fix e2e test * remove some useless code * fix sp exit test * add more sp exit test and fix some bugs * using id instead of address for some interfaces and events * fix some tests * fix e2e * fix unit test * add more check and parmas check * fix e2e tests * fix an issue * fix sp test * fix ci lint * remove useless code (#308) * chore: refine payment for gvg settle (#309) * chore: refine gvg staking per bytes and default params (#310) * rename gvgstakingprice to gvgstakingperbytes * fix DefaultMaxStoreSizePerFamily * feat: add chainId to bls sign doc (#313) * add chainId to bls sign doc * get chain id from cosmos context * feat: refine swap out and migrate bucket (#311) * fix: update swagger (#317) * feat: enhance head object api (#321) * fix gnfd query api (#318) * feat: update challenge and stop serving for sp exit (#322) * feat: fix review comments of sp exit (#320) * fix code review tips (#325) * fix cosmos sdk version * fix e2e test case * fix review tips
fynnss
added a commit
that referenced
this pull request
Jul 13, 2023
* init virtual group module * add create/delete/deposit/withdraw/swapout messages * add sp keeper dependency * add router and type function * refactor sequence to support uint32 and U256 * impl virtual group module * refactor storage module * refactor challenge module to algin the new design * self review code * fix testcase and punish code * fix challenge testcases * refactor payment module to algin the new design * add e2e test * fix some unit tests * update cosmos-sdk * update go mod * fix e2e test * store deposit * update gomod * fix some e2e test case * fix cancel create object * ignore error for testing * fix storage test * fix test case * make GetGVG more simple * add virtual group swap out message * fix swap out * add event * fix ignite missing placeholder * add sp exit message * add sp exit * complete sp exit * add swap deposit * remove virtual payment account from local virtual group/ event * complete sp exit process * fix mock file error * add mock gen * fix swap out as secondary sp error * refator payment * refactor approval to get more extends * fix payment unit test * add withdraw cli * revert extends of approval * refactor payment for settlement and resume * refactor payment for out flow * fix proto * add basic migration bucket logic * fix the sp exit * refine the code * add payment for bucket migration * refactor code * fix some issues * fix issue and unit tests * add migration check and rebinding * refine the code * refactor withdraw from gvg & gvg family * feat: use bls sig in sealObject by secondary sps (#283) * fix gensp test error * add more check and params * add some unit tests for payment * fix compile error * add exit,completeexit, swapout events * add migration event * add create gvg family event * mirror update * fix lint issues * fix lint issues * fix some unit tests * fix the limit of gvgs and lvgs * fix bucket migration * fix address issues for new messages * refine challenge module * refine payment module * fix basesuite for create so many families * fix lint * add deposit/withdraw test for virtual group * fix issue of iterator * add basic sp exit test and fix some bugs * fix issue and refactor e2e tests * add e2e test cases * fix and add e2e test cases * refactor e2e test * add sp swap out test * refine code by cr * fix some review comments * fix cr suggestion * fix some review comments * refine the code * calculate sp num instead of constant * add migration e2e test * feat: bls sig for complete migrate bucket (#291) * fix bucket migration issue * update cosmos sdk version * fix migration bucket e2e test * fix CodeReview issues * fix some bugs * update staking per GB * refine some var * fix RebindingGVGsToBucket revert error * feat: Local virtual group and Billing info refacot (#306) * fix challenge refactor * fix some review tips * fix internal bucket info error * add family id to CreateBucketEvent * refactor challenge module * refactor payment module * fix redundany GenId * add family id check * refactor payment module * fix error * refactor payment module * fix issue * implement virtual group cmd * refine the comments of protobuf * fix e2e test * remove some useless code * fix sp exit test * add more sp exit test and fix some bugs * using id instead of address for some interfaces and events * fix some tests * fix e2e * fix unit test * add more check and parmas check * fix e2e tests * fix an issue * fix sp test * fix ci lint * remove useless code (#308) * chore: refine payment for gvg settle (#309) * chore: refine gvg staking per bytes and default params (#310) * rename gvgstakingprice to gvgstakingperbytes * fix DefaultMaxStoreSizePerFamily * feat: add chainId to bls sign doc (#313) * add chainId to bls sign doc * get chain id from cosmos context * feat: refine swap out and migrate bucket (#311) * fix: update swagger (#317) * feat: enhance head object api (#321) * fix gnfd query api (#318) * feat: update challenge and stop serving for sp exit (#322) * feat: fix review comments of sp exit (#320) * fix code review tips (#325) * fix cosmos sdk version * fix e2e test case * fix review tips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes some review comments about payment in sp exit pr.
Rationale
Fix review comments.
Example
NA
Changes
Notable changes: