Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying limits for rolling graph builder #927

Merged
merged 17 commits into from
Jul 5, 2022

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Jun 9, 2022

This PR adds extended visualization configuration options for the builders in the design visualizers package, to allow specifying range and capacity limits. For consistency, we are also obsoleting redundant visualization properties in the builder nodes.

Fixes #926
Fixes #858

@glopesdev glopesdev added this to the 2.7.0 milestone Jun 9, 2022
@glopesdev glopesdev added the feature New planned feature label Jun 9, 2022
@glopesdev
Copy link
Member Author

glopesdev commented Jun 11, 2022

For certain applications, it is useful to be able to specify "hard" limits for the visualizer, in cases where the range is fixed and known. However, it can also be useful to allow for runtime editable ranges where the range is unknown or experiment-specific.

To allow for both situations, we could expose range properties in the builder classes that take precedence over visualizer editable ranges, but only if they are specified.

@glopesdev
Copy link
Member Author

Since BarGraphVisualizer dynamically updates the last index value, it would make sense to use it as a dictionary, and consider allowing updating values of pre-existing indexes.

@glopesdev glopesdev merged commit e390ef2 into bonsai-rx:master Jul 5, 2022
@glopesdev glopesdev deleted the issue-926 branch July 5, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
1 participant