Add support for unit testing #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncguilbeault
force-pushed
the
automated-tests
branch
from
a2c3613
to
2af7d25
Compare
glopesdev
reviewed
Jun 14, 2024
tests/Bonsai.ML.LinearDynamicalSystems.Tests/Bonsai.ML.LinearDynamicalSystems.Tests.csproj
Outdated
Show resolved
Hide resolved
Run workflow directly from the test folder
PythonEngine shutdown currently relies on BinaryFormatter which has been deprecated with .NET 8. This is a known issue documented at: pythonnet/pythonnet#2282
glopesdev
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for automated unit testing. It also includes a unit test to compare outputs from Bonsai and Python running the LDS model for linear regression.
Change to solution file
The Bonsai.ML.sln file is pulled out from the
srcfolder and into the main repo. This allows the solution file to have a structured hierarchy which encompass bothsrcandtests, consistent with other .NET projects (e.g. ml.net).Test workflow
The
test.ymlgithub workflow will build the solution and run tests on the solution. If the test requires running a Bonsai workflow, the individual unit test should include a Bonsai.config file for recreating the bonsai environment.Receptive field simple cell test
The
tests/Bonsai.ML.LinearDynamicalSystems.Tests/ReceptiveFieldSimpleCellTestfolder contains a test method to download the data, setup a python and Bonsai environment with the necessary packages installed, generate the python and Bonsai outputs and compare.