feat: Change encryption to AEAD XChaCha20 Poly1305 #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Currently only have encrypting wrote (not sure if it works). |
|
https://discord.com/channels/825407338755653642/887255721392099378/1285665235612733592 lol Discord changed encryption again, what a joke. |
|
we need to get this working then progress on to dave, lets split it into 2 parts |
|
Will do it over the weekend :)
…On Wed, 18 Sep 2024 at 22:08, Craig Edwards (Brain) < ***@***.***> wrote:
we need to get this working then progress on to dave, lets split it into 2
parts
—
Reply to this email directly, view it on GitHub
<#1239 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALF2B6M2TGN2PUIAQKHCDKTZXHTWBAVCNFSM6AAAAABNPFUXZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGQYDOOJQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
AEAD XChaCha20 Poly1305 (RTP Size)as the encryption method for voice data.AEAD AES256-GCM (RTP Size)will not be introduced in this PR as it is simply a suggestion (Discord declares it as a "preference", however, it's easier to just stick withXChaCha20 Poly1305) therefore, after discussions internally, we will stick with justAEAD XChaCha20 Poly1305 (RTP Size)Code change checklist