Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add google auth login option #1255

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: add google auth login option #1255

wants to merge 7 commits into from
+225 −51

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented Jul 17, 2024 •
edited
Loading

Permit those with allowed hosted domains to login via Google SSO

Screenshare.-.2024-07-18.11_32_14.AM.mp4

@IanKrieger IanKrieger changed the title Feat/google auth feat: add google auth login option Jul 17, 2024
@diracdeltas diracdeltas requested a review from bcaller July 17, 2024 20:00
bcaller
bcaller approved these changes Jul 18, 2024
View reviewed changes
Copy link

@bcaller bcaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. May need to add code to fetch nonce if we decide to do that.

@IanKrieger IanKrieger marked this pull request as ready for review July 18, 2024 15:37
@IanKrieger IanKrieger requested review from tackley and a team as code owners July 18, 2024 15:37
@github-actions GitHub Actions
Copy link

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "login" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for two months with no activity. Remove stale label or add a comment to avoid this being closed in a weeks time.

@github-actions github-actions bot added the stale pending closure due to inactivity label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thypon thypon thypon approved these changes

@bcaller bcaller bcaller approved these changes

@tackley tackley Awaiting requested review from tackley tackley is a code owner

Assignees

@thypon thypon

@bcaller bcaller

Labels
depends-on-server-release needs-security-review stale pending closure due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanKrieger @thypon @bcaller