-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create libmysql.a using dlltool.exe on mingw64 #473
Conversation
Looking at the Connector/C 6.1.3 Windows 64 zip file, libmysql.dll is 4.8MB, while libmysql.lib is 12KB. I'd guess the .lib isn't actually useful? Should we more aggressively try to copy the libmysql.whatev into the same directory as the compiled mysql2 gem output? |
I can help with testing on Win box. Would be compile + passing test suite enough? |
@simi I'd be happy to take you up on testing this! I'd like to get it in for 0.3.17 soon. |
db64310
to
d8acbfd
Compare
I will rebase/squash the crap out of this branch later in the week. I can't believe I got this thing to build and run specs finally. Props to @appveyor for providing a free Windows CI service! |
0b85a00
to
e8846b9
Compare
At long last, I believe this is done. Anybody following the thread, please review code and test it out! |
In "Wrap vendor:mysql tasks with a platform argument" each of the platform Connector-C zip files are fetched and unzipped in |
Create libmysql.a using dlltool.exe on mingw64
Fix syntax for cross_config_options. Only invoke vendor:mysql when compiling for Windows. Only invoke vendor:mysql twice when cross-compiling for Windows.
Fix syntax for cross_config_options. Only invoke vendor:mysql when compiling for Windows. Only invoke vendor:mysql twice when cross-compiling for Windows.
Fix syntax for cross_config_options. Only invoke vendor:mysql when compiling for Windows. Only invoke vendor:mysql twice when cross-compiling for Windows.
Three fixes to Windows build errors since #473
I released mysql2 version 0.3.18 with windows binaries today! |
I have no idea if this will work.It works! See #469.