Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create libmysql.a using dlltool.exe on mingw64 #473

Merged
merged 16 commits into from
Jan 10, 2015

Conversation

sodabrew
Copy link
Collaborator

I have no idea if this will work. It works! See #469.

@sodabrew
Copy link
Collaborator Author

Looking at the Connector/C 6.1.3 Windows 64 zip file, libmysql.dll is 4.8MB, while libmysql.lib is 12KB. I'd guess the .lib isn't actually useful?

Should we more aggressively try to copy the libmysql.whatev into the same directory as the compiled mysql2 gem output?

@simi
Copy link
Contributor

simi commented Apr 7, 2014

I can help with testing on Win box. Would be compile + passing test suite enough?

@sodabrew sodabrew modified the milestones: 0.3.17, 0.3.16 May 15, 2014
@sodabrew sodabrew removed this from the 0.3.17 milestone Sep 20, 2014
@sodabrew
Copy link
Collaborator Author

@simi I'd be happy to take you up on testing this! I'd like to get it in for 0.3.17 soon.

@sodabrew
Copy link
Collaborator Author

sodabrew commented Oct 5, 2014

I will rebase/squash the crap out of this branch later in the week. I can't believe I got this thing to build and run specs finally. Props to @appveyor for providing a free Windows CI service!

@sodabrew sodabrew closed this Jan 2, 2015
@sodabrew sodabrew reopened this Jan 2, 2015
@sodabrew sodabrew force-pushed the mingw64 branch 2 times, most recently from 0b85a00 to e8846b9 Compare January 7, 2015 23:05
@sodabrew
Copy link
Collaborator Author

sodabrew commented Jan 7, 2015

At long last, I believe this is done. Anybody following the thread, please review code and test it out!

@sodabrew
Copy link
Collaborator Author

sodabrew commented Jan 8, 2015

In "Wrap vendor:mysql tasks with a platform argument" each of the platform Connector-C zip files are fetched and unzipped in rake-compiler-dev-box.

sodabrew added a commit that referenced this pull request Jan 10, 2015
Create libmysql.a using dlltool.exe on mingw64
@sodabrew sodabrew merged commit 72deddd into brianmario:master Jan 10, 2015
@sodabrew sodabrew deleted the mingw64 branch January 21, 2015 21:50
sodabrew added a commit to sodabrew/mysql2 that referenced this pull request Feb 9, 2015
Fix syntax for cross_config_options.
Only invoke vendor:mysql when compiling for Windows.
Only invoke vendor:mysql twice when cross-compiling for Windows.
sodabrew added a commit to sodabrew/mysql2 that referenced this pull request Feb 9, 2015
Fix syntax for cross_config_options.
Only invoke vendor:mysql when compiling for Windows.
Only invoke vendor:mysql twice when cross-compiling for Windows.
sodabrew added a commit to sodabrew/mysql2 that referenced this pull request Feb 9, 2015
Fix syntax for cross_config_options.
Only invoke vendor:mysql when compiling for Windows.
Only invoke vendor:mysql twice when cross-compiling for Windows.
sodabrew added a commit that referenced this pull request Feb 9, 2015
Three fixes to Windows build errors since #473
@sodabrew
Copy link
Collaborator Author

I released mysql2 version 0.3.18 with windows binaries today!
If you find a problem with the 0.3.18 version, please open a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants